From ca47e0d01d002c6e062b030bda641259ef906aae Mon Sep 17 00:00:00 2001
From: Matt Zeunert <matt@mostlystatic.com>
Date: Thu, 2 May 2019 09:59:15 +0100
Subject: [PATCH] Make getBoundingRect take array of rects

---
 lighthouse-core/lib/rect-helpers.js   | 24 +++++++-----------------
 lighthouse-core/lib/tappable-rects.js |  2 +-
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/lighthouse-core/lib/rect-helpers.js b/lighthouse-core/lib/rect-helpers.js
index 5bae4486e8ea..ced6ba6b148d 100644
--- a/lighthouse-core/lib/rect-helpers.js
+++ b/lighthouse-core/lib/rect-helpers.js
@@ -92,12 +92,12 @@ function rectsTouchOrOverlap(rectA, rectB) {
 
 /**
  * Returns a bounding rect for all the passed in rects, with padded with half of
- * `minimumSize` on all sides.
+ * `padding` on all sides.
  * @param {LH.Artifacts.Rect[]} rects
- * @param {number} minimumSize
+ * @param {number} padding
  * @return {LH.Artifacts.Rect}
  */
-function getBoundingRectWithPadding(rects, minimumSize) {
+function getBoundingRectWithPadding(rects, padding) {
   if (rects.length === 0) {
     throw new Error('No rects to take bounds of');
   }
@@ -114,7 +114,7 @@ function getBoundingRectWithPadding(rects, minimumSize) {
   }
 
   // Pad on all sides.
-  const halfMinSize = minimumSize / 2;
+  const halfMinSize = padding / 2;
   left -= halfMinSize;
   right += halfMinSize;
   top -= halfMinSize;
@@ -131,20 +131,10 @@ function getBoundingRectWithPadding(rects, minimumSize) {
 }
 
 /**
- * @param {LH.Artifacts.Rect} rectA
- * @param {LH.Artifacts.Rect} rectB
+ * @param {LH.Artifacts.Rect[]} rects
  */
-function getBoundingRect(rectA, rectB) {
-  const left = Math.min(rectA.left, rectB.left);
-  const right = Math.max(rectA.right, rectB.right);
-  const top = Math.min(rectA.top, rectB.top);
-  const bottom = Math.max(rectA.bottom, rectB.bottom);
-  return addRectWidthAndHeight({
-    left,
-    right,
-    top,
-    bottom,
-  });
+function getBoundingRect(rects) {
+  return getBoundingRectWithPadding(rects, 0);
 }
 
 /**
diff --git a/lighthouse-core/lib/tappable-rects.js b/lighthouse-core/lib/tappable-rects.js
index c060fb2ade69..fa86933c5983 100644
--- a/lighthouse-core/lib/tappable-rects.js
+++ b/lighthouse-core/lib/tappable-rects.js
@@ -72,7 +72,7 @@ function mergeTouchingClientRects(clientRects) {
         (rectsLineUpHorizontally || rectsLineUpVertically);
 
       if (canMerge) {
-        const replacementClientRect = getBoundingRect(crA, crB);
+        const replacementClientRect = getBoundingRect([crA, crB]);
         const mergedRectCenter = getRectCenterPoint(replacementClientRect);
 
         if (