From 992c6400e744bd1d2f0d85a36b428317f3da65bd Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 30 Sep 2019 16:35:15 -0700 Subject: [PATCH 1/6] docs: update stale references to first-interactive --- docs/configuration.md | 6 +++--- docs/readme.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/configuration.md b/docs/configuration.md index 2419204e6ba2..4abba6b92884 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -17,7 +17,7 @@ module.exports = { 'first-meaningful-paint', 'speed-index-metric', 'estimated-input-latency', - 'first-interactive', + 'first-cpu-idle', 'consistently-interactive', ], }, @@ -129,7 +129,7 @@ The audits property controls which audits to run and include with your Lighthous { audits: [ 'first-meaningful-paint', - 'first-interactive', + 'first-cpu-idle', 'byte-efficiency/uses-optimized-images', ] } @@ -151,7 +151,7 @@ The categories property controls how to score and organize the audit results in description: 'This category judges your performance', auditRefs: [ {id: 'first-meaningful-paint', weight: 2, group: 'metrics'}, - {id: 'first-interactive', weight: 3, group: 'metrics'}, + {id: 'first-cpu-idle', weight: 3, group: 'metrics'}, {id: 'consistently-interactive', weight: 5, group: 'metrics'}, ], } diff --git a/docs/readme.md b/docs/readme.md index a397dbd5a452..189bc5165abb 100644 --- a/docs/readme.md +++ b/docs/readme.md @@ -94,7 +94,7 @@ In order to extend the Lighthouse configuration programmatically, you need to pa 'first-meaningful-paint', 'speed-index-metric', 'estimated-input-latency', - 'first-interactive', + 'first-cpu-idle', 'consistently-interactive', ], }, From eaffe06887ad84aff4f997da7259046c93364ce8 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 30 Sep 2019 17:31:45 -0700 Subject: [PATCH 2/6] pr --- docs/readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/readme.md b/docs/readme.md index 189bc5165abb..4a08a978d01b 100644 --- a/docs/readme.md +++ b/docs/readme.md @@ -92,10 +92,10 @@ In order to extend the Lighthouse configuration programmatically, you need to pa settings: { onlyAudits: [ 'first-meaningful-paint', - 'speed-index-metric', + 'speed-index', 'estimated-input-latency', 'first-cpu-idle', - 'consistently-interactive', + 'interactive', ], }, } From e86ca9001e12d82bae67bcebe70a7ffbbe825950 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Thu, 3 Oct 2019 14:49:38 -0500 Subject: [PATCH 3/6] Apply suggestions from code review --- docs/configuration.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/configuration.md b/docs/configuration.md index 4abba6b92884..546636870f59 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -15,10 +15,10 @@ module.exports = { settings: { onlyAudits: [ 'first-meaningful-paint', - 'speed-index-metric', + 'speed-index', 'estimated-input-latency', 'first-cpu-idle', - 'consistently-interactive', + 'interactive', ], }, }; From 23104e2536a8a03080b2597092e72e8a8851a7e3 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Thu, 3 Oct 2019 14:50:23 -0500 Subject: [PATCH 4/6] Update docs/configuration.md --- docs/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/configuration.md b/docs/configuration.md index 546636870f59..7221c80772cb 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -152,7 +152,7 @@ The categories property controls how to score and organize the audit results in auditRefs: [ {id: 'first-meaningful-paint', weight: 2, group: 'metrics'}, {id: 'first-cpu-idle', weight: 3, group: 'metrics'}, - {id: 'consistently-interactive', weight: 5, group: 'metrics'}, + {id: 'interactive', weight: 5, group: 'metrics'}, ], } } From 89c57914c48e28c73497ad6b1e5889feb75aff8e Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Fri, 4 Oct 2019 10:39:49 -0700 Subject: [PATCH 5/6] rm eid --- docs/readme.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/readme.md b/docs/readme.md index 4a08a978d01b..1d379e61690e 100644 --- a/docs/readme.md +++ b/docs/readme.md @@ -93,7 +93,6 @@ In order to extend the Lighthouse configuration programmatically, you need to pa onlyAudits: [ 'first-meaningful-paint', 'speed-index', - 'estimated-input-latency', 'first-cpu-idle', 'interactive', ], From 5c529bd746e8470d2c62607cdb158cc8fec1df77 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Fri, 4 Oct 2019 10:40:29 -0700 Subject: [PATCH 6/6] rm eid --- docs/configuration.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/configuration.md b/docs/configuration.md index 7221c80772cb..e49f3174c1cd 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -16,7 +16,6 @@ module.exports = { onlyAudits: [ 'first-meaningful-paint', 'speed-index', - 'estimated-input-latency', 'first-cpu-idle', 'interactive', ],