This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Refactors the tests of cache expiration options. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Sep 22, 2016
| const assertCacheContents = (cachedAssets, expectedUrls) => { | ||
| const expectedLength = expectedUrls.length; | ||
| const cachedUrls = Object.keys(cachedAssets); | ||
| const filteredUrls = cachedUrls.filter(url => expectedUrls.includes(url)); |
There was a problem hiding this comment.
Not sure of when filteredUrls != cachedUrls and that would be OK.
Would it make sense to invert the includes check and ensure filteredUrls.length === 0?
There was a problem hiding this comment.
All of the tests in this file assume that the cached contents need to be exactly equal to the expected contents. I.e., if there's something in cached contents that's not in expected, or vice versa, then it's a failure. This logic seemed like the easiest way to check that bijection.
It's not really a general-purpose check that's applicable to other tests, since other tests might be implemented in such a way that extra entries in the cached contents that aren't expected wouldn't be considered a failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface
CC: @addyosmani
This fixes up a test that was flaky due to the need to clear out IDB in between invocations, which didn't always succeed due to the DB instance being held open in the service worker.
It's a refactoring of the logic so that it's no longer necessary to clear out IDB, since there's a separate DB instance used for each individual sub-test (scoped to the service worker registration).
I also took the opportunity to refactor some of the promise chains to make them more readable, and move common logic out to helper functions.