fix: correctly process NoSuchUserContextException in cookie operations
#1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
changed the title
NoSuchUserContextException in cookie operaеionsNoSuchUserContextException in cookie operations
sadym-chromium
force-pushed
the
sadym/cookie-unknown-user-context
branch
from
69e21bc to
08a2caa
Compare
OrKoN
approved these changes
Mar 5, 2024
OrKoN
changed the title
NoSuchUserContextException in cookie operationsNoSuchUserContextException in cookie operations
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Lightning00Blade
pushed a commit
that referenced
this pull request
Mar 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.13](chromium-bidi-v0.5.12...chromium-bidi-v0.5.13) (2024-03-15) ### Features * `invalid selector` error ([#1985](#1985)) ([cba1d35](cba1d35)) * add support for `contexts` in `addInterception` ([#1945](#1945)) ([fc76be7](fc76be7)) * start implementing `browsingContext.locateNodes` ([#1970](#1970)) ([d61f154](d61f154)) * support `network.continueResponse` authorization ([#1961](#1961)) ([528ad63](528ad63)) * support base64 cookie values ([#1933](#1933)) ([9d1b975](9d1b975)) * support xpath locators ([#1986](#1986)) ([b49184f](b49184f)) ### Bug Fixes * add `authChallenges` to response ([#1919](#1919)) ([e4a519a](e4a519a)) * always provide `userContext` in cookie's `partitionKey` ([#1938](#1938)) ([0adf6d1](0adf6d1)) * correctly process `NoSuchUserContextException` in cookie operations ([#1940](#1940)) ([7407608](7407608)) * don't block on unsubscribed events ([#1954](#1954)) ([0abbff8](0abbff8)) * don't throw unhandled errors ([#1996](#1996)) ([ab1c6d2](ab1c6d2)) * emit for target id ([#1979](#1979)) ([d1091bd](d1091bd)) * the pattern matching logic ([#1995](#1995)) ([66010d1](66010d1)) * workaround issue with Script.Target ([#1947](#1947)) ([3cc317b](3cc317b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse error when setting/getting cookies to catch
NoSuchUserContextException.test_cookie_set_partition_user_contextto test what it was intended to.