fix: don't block data url events when interception is enabled #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Mar 27, 2024
|
This should not be needed I miss read some Puppereer logs. Will close once I verify. |
Lightning00Blade
changed the title
OrKoN
reviewed
Mar 27, 2024
Lightning00Blade
force-pushed
the
fix-reponse-data-url
branch
from
84cd97b to
35ac48e
Compare
OrKoN
approved these changes
Mar 27, 2024
Lightning00Blade
pushed a commit
that referenced
this pull request
Mar 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.16](chromium-bidi-v0.5.15...chromium-bidi-v0.5.16) (2024-03-27) ### Features * support body in `network.continueRequest` ([#2075](#2075)) ([d0c4955](d0c4955)) ### Bug Fixes * add fragment to url ([#2079](#2079)) ([d416b6c](d416b6c)) * do not expect init or commit to arrive ([#2080](#2080)) ([d37d406](d37d406)) * don't block data url events when interception is enabled ([#2081](#2081)) ([1350b3b](1350b3b)) * emit `network.beforeRequestSent` event for data urls ([#2073](#2073)) ([5162b0a](5162b0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2035