fix(browsingContext): emit navigationFailed for navigate command failure
#2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Apr 9, 2024
Lightning00Blade
force-pushed
the
chore-fix
branch
2 times, most recently
from
e5ef225 to
ff0541c
Compare
Lightning00Blade
force-pushed
the
chore-fix
branch
from
ff0541c to
f97e1ba
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
Apr 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.17](chromium-bidi-v0.5.16...chromium-bidi-v0.5.17) (2024-04-10) ### Features * **network:** support more props for `initiator` ([#2115](#2115)) ([80dd9e6](80dd9e6)) ### Bug Fixes * **browsingContext:** emit `navigationFailed` for `navigate` command failure ([#2118](#2118)) ([382a762](382a762)) * don't expect interception for cached events ([#2087](#2087)) ([063c1d1](063c1d1)) * emit `network.responseCompleted` for redirects ([#2098](#2098)) ([219cfc9](219cfc9)) * **network:** support Interception for OOPIF ([#2110](#2110)) ([5d0845c](5d0845c)) * **script:** support PreloadScript in OOPIF ([#2109](#2109)) ([baa263e](baa263e)) * sending undefined viewport should keep previously set viewport ([#2119](#2119)) ([823e52d](823e52d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2035
This unblock part of the Puppeteer implementation to properly handle navigation that originated from
browsingContext.navigateand failed.