Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar needs a healthcheck #12

Closed
markmandel opened this issue Dec 7, 2017 · 1 comment
Closed

Sidecar needs a healthcheck #12

markmandel opened this issue Dec 7, 2017 · 1 comment
Assignees
@dzlier-gcp
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone
0.1

Comments

@markmandel
Copy link
Member

markmandel commented Dec 7, 2017 •
edited
Loading

The sidecar needs a health check, and a restart if it fails.

This would likely be a HTTP health check, so will need to run the http server in it in it's own goroutine.

Controller version was implemented in #34 - check there for reference.
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones labels Dec 7, 2017
@markmandel markmandel added this to the 0.1 milestone Jan 3, 2018
@dzlier-gcp dzlier-gcp self-assigned this Jan 3, 2018
@dzlier-gcp dzlier-gcp mentioned this issue Jan 3, 2018
Merged
@markmandel
Copy link
Member Author

Completed by #44

@markmandel markmandel mentioned this issue May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzlier-gcp dzlier-gcp

Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@markmandel @dzlier-gcp