Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the entrypoint from the build-image #28

Closed
markmandel opened this issue Dec 14, 2017 · 1 comment
Closed

Remove the entrypoint from the build-image #28

markmandel opened this issue Dec 14, 2017 · 1 comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
0.1

Comments

@markmandel
Copy link
Member

We so rarely call kubectl directly, remove it from the build-image/Dockerfile

Then go through the Makefile and switch to the standard CMD docker run pattern instead.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc good first issue These are great first issues. If you are looking for a place to start, start here! area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Dec 14, 2017
@markmandel
Copy link
Member Author

This was removed in #35 - but will leave this ticket open until all the entrypoint commands are gone from build/Makefile

@cyriltovena cyriltovena mentioned this issue Feb 9, 2018
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel