Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running the SDK sidecar in local mode, be able to specify the backing GameServer configuration #296

Closed
victor-prodan opened this issue Jul 19, 2018 · 3 comments
Closed

When running the SDK sidecar in local mode, be able to specify the backing GameServer configuration #296

victor-prodan opened this issue Jul 19, 2018 · 3 comments
Assignees
@markmandel
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone
0.4.0

Comments

@victor-prodan
Copy link
Contributor

I am testing locally the game server with the sidecar launched independently in --local mode.
The thing is that in this case, the name of the port created by the sidecar ("default") does not match the name of the port from the yaml file used with a real deployment.
I would like to be able at least to change the "default" port name.
@cyriltovena
Copy link
Collaborator

@victor-prodan are we talking about the grpc/http or gameserver port ?

@markmandel
Copy link
Member

What about this idea: If you could optionally specify a GameServer yaml file that you could pass in, that would be the details that are passed back when you want the GameServer configuration.

Something like:

sdk-server.linux.amd64 --local -f gameserver.yaml

Would that work? Seems like the most flexible.

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 19, 2018
@victor-prodan
Copy link
Contributor Author

I was talking about gameserver port and yes, specifying the gameserver.yaml would be perfect!

@markmandel markmandel added the kind/design Proposal discussing new features / fixes and how they should be implemented label Jul 19, 2018
@markmandel markmandel changed the title When running the SDK sidecar in local mode, be able to specify the port configuration When running the SDK sidecar in local mode, be able to specify the backing GameServer configuration Jul 19, 2018
@markmandel markmandel added this to the 0.4.0 milestone Jul 30, 2018
@markmandel markmandel mentioned this issue Aug 1, 2018
Closed
@markmandel markmandel self-assigned this Aug 24, 2018
markmandel added a commit to markmandel/agones that referenced this issue Aug 26, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
ec7cfa0 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
markmandel added a commit to markmandel/agones that referenced this issue Aug 26, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
e784314 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
@markmandel markmandel mentioned this issue Aug 26, 2018
Merged
markmandel added a commit to markmandel/agones that referenced this issue Aug 26, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
8e1141a 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
markmandel added a commit to markmandel/agones that referenced this issue Aug 27, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
a486366 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
markmandel added a commit that referenced this issue Aug 27, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
383bd22 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes #296
victor-prodan pushed a commit to victor-prodan/agones that referenced this issue Sep 3, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
a296dba 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
victor-prodan pushed a commit to victor-prodan/agones that referenced this issue Sep 3, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
14f47a5 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
victor-prodan pushed a commit to victor-prodan/agones that referenced this issue Sep 3, 2018
@markmandel
Ability to pass GameServer yaml/json to local sdk server
d39d259 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
slartibaartfast pushed a commit to slartibaartfast/agones that referenced this issue Sep 10, 2018
@markmandel @slartibaartfast
Ability to pass GameServer yaml/json to local sdk server
2b70ace 
To be able to work locally, you need to be able to specify your
local `GameServer` configuration, as it likely will have application specific
configuration in it -- or maybe you want to specify what state it's in.

This commit allow you to specify the local resource as either yaml/json
through a `-f` or `--file` flag.

Closes googleforgames#296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
3 participants
@markmandel @cyriltovena @victor-prodan