Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameServers should have the Fleet name in a label for easy retrieval #411

Closed
markmandel opened this issue Nov 9, 2018 · 0 comments
Closed

GameServers should have the Fleet name in a label for easy retrieval #411

markmandel opened this issue Nov 9, 2018 · 0 comments
Labels
area/performance Anything to do with Agones being slow, or making it go faster. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone
0.7.0

Comments

@markmandel
Copy link
Member

Especially for those building their own integrations with Agones - its difficult to traverse Fleet -> GameServerSet -> GameServers if they want to get a list of GameServers for a given Fleet

So I suggest we add the fleet name as a label and value to the GameServer to make this easier.

Basically we should replicate what we do here for GameServerSets (although we may want to refactor some names):
https://github.com/GoogleCloudPlatform/agones/blob/master/pkg/apis/stable/v1alpha1/fleet.go#L102

This will also mean that we can do a more efficient version of ListGameServersByFleetOwner:
https://github.com/GoogleCloudPlatform/agones/blob/master/pkg/fleets/fleets.go#L48
as well.
@markmandel markmandel added kind/feature New features for Agones kind/design Proposal discussing new features / fixes and how they should be implemented area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc area/performance Anything to do with Agones being slow, or making it go faster. help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Nov 9, 2018
@cyriltovena cyriltovena mentioned this issue Nov 27, 2018
Merged
@markmandel markmandel added this to the 0.7.0 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance Anything to do with Agones being slow, or making it go faster. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@markmandel