Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcloud-auth-cluster: Create unique name for cluster role binding #662

Closed
markmandel opened this issue Mar 17, 2019 · 1 comment · Fixed by #666
Closed

gcloud-auth-cluster: Create unique name for cluster role binding #662

markmandel opened this issue Mar 17, 2019 · 1 comment · Fixed by #666
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
0.9.0

Comments

@markmandel
Copy link
Member

In theory, the cluster role binding name that we hard code could already exist (maybe someone else set up the cluster by hand).

I think it would be nice to take a short hash of the user's account name (or any other relatively unique identifier), and incorporate that into the name of the cluster role binding in gcloud-auth-cluster
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Mar 17, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Mar 18, 2019

I am thinking of something cross-platform like this hash:

accountHash := $(shell echo - n $$(gcloud config get-value account) | openssl md5)

@aLekSer aLekSer mentioned this issue Mar 19, 2019
Merged
@markmandel markmandel added this to the 0.9.0 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Add hash of account to clusterrolebinding name to support multiple accounts aLekSer/agones
2 participants
@markmandel @aLekSer