Packed: Fleet scaled down removes GameServers from least used Nodes #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
markmandel
changed the title
|
Build Failed 😱 Build Id: ba1f7fc2-6889-4b42-a3fb-3ad9113577de Build Logs |
markmandel
force-pushed
the
feature/fleet-scale-down
branch
from
4d53112 to
ed1c1d1
Compare
|
Build Succeeded 👏 Build Id: 3ddbc2c9-d8e3-4e15-af83-633ed2ae1d27 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
commented
Oct 26, 2018
EricFortin
reviewed
Oct 29, 2018
EricFortin
approved these changes
Oct 29, 2018
| }) | ||
|
|
||
| // we need to get Ready GameServer until we equal or pass limit | ||
| result := make([]*v1alpha1.GameServer, 0, limit) |
markmandel
changed the title
|
@EricFortin Oops - yep, changed the title! |
markmandel
force-pushed
the
feature/fleet-scale-down
branch
from
ed1c1d1 to
6e38a64
Compare
|
Build Failed 😱 Build Id: 3f17058c-1be6-4eb6-9169-92dc89b2b494 Build Logs |
1 similar comment
|
Build Failed 😱 Build Id: 3f17058c-1be6-4eb6-9169-92dc89b2b494 Build Logs |
markmandel
force-pushed
the
feature/fleet-scale-down
branch
from
6e38a64 to
957987a
Compare
|
Build Succeeded 👏 Build Id: 773d88f4-0142-4829-86ee-cad85262ae59 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
This implements the strategy such that when a Fleet is scaled down, and has the "Packed" strategy, it removed GameServers from Nodes that have the least GameServers running on them. This also fixes up some issues with the OpenAPI validation as well. THis looks like it's working. Go team.
markmandel
force-pushed
the
feature/fleet-scale-down
branch
from
957987a to
3d87fe7
Compare
|
Build Succeeded 👏 Build Id: 7c33353d-02ad-4a98-902c-ed70f887dd8b The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the strategy such that when a Fleet is scaled down, and
has the "Packed" strategy, it removed GameServers from Nodes that have the
least GameServers running on them.
This also fixes up some issues with the OpenAPI validation as well.
(Sorry - there was a bunch of cleanup in here, lemme know if you want me to point out the most important sections - basically controller.go and
filterGameServersOnLeastFullNodesimplementation)