Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fix for goroutines leak #461

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Apply fix for goroutines leak #461

merged 1 commit into from
Dec 26, 2018

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Dec 26, 2018

Fixes #414 CPU leak.
Fix is proposed by next pull request, which have not merged yet.
https://github.com/kubernetes/kubernetes/pull/70277/files

@aLekSer
Apply fix for goroutines leak
30de9cd 
Fixes googleforgames#414 CPU leak.
Fix is proposed by next pull request, which have not merged yet.
https://github.com/kubernetes/kubernetes/pull/70277/files
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 52f3fdab-48ee-4731-8685-018be5033373

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/461/head:pr_461 && git checkout pr_461
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-30de9cd

@markmandel markmandel added this to the 0.7.0 milestone Dec 26, 2018
@markmandel markmandel added kind/bug These are bugs. area/performance Anything to do with Agones being slow, or making it go faster. labels Dec 26, 2018
markmandel
markmandel approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit a7c4dcd into googleforgames:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/bug These are bugs.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel