Fix for health check stability issues #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of race conditions, on non-warm CI builds, health checks can occasionally fail. This should solve this problem 🤞
markmandel
added
kind/bug
|
@dzlier-gcp I think this will solve the issue with the healthchecks we've been seeing. Also figured you might be interested - it's also a nice little util lib backed into K8s's client-go. |
|
LGTM, though any time I see duplicated code like this (which is partially my fault since I did 1.5 of the health checks) it makes me itch. I wonder if, when, and in what way we could consolidate any of this. |
|
I tend to work on a 'if you do something 3 times, then consolidate' - but if you feel strongly, happy to look at PRs ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of race conditions, on non-warm CI builds, health checks can occasionally fail.
This should solve this problem 🤞