-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setAnnotation for simple-udp to use customized key & value #576
fix setAnnotation for simple-udp to use customized key & value #576
Conversation
Build Failed 😱 Build Id: 068cabf2-77bf-4408-9fda-81ab4da5c7e4 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
this needs to be built and pushed to container registry, let me do it, then your test will pass. |
can you sync your tree to the latest version and rebase so this commit is minimal? |
Build Succeeded 👏 Build Id: 4107f2fb-246f-4c90-903e-4a75a8b417dd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 0da0b51a-d1eb-4c0c-8e11-6eb889f8b189 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@jkowalski this LGTM - you got any issues, or can we push this through? |
@jkowalski - I didn't see commit related to udp-server:0.7 on https://github.com/GoogleCloudPlatform/agones/commits/master. Do I still need to sync to the latest version? or this can be pulled directly? |
Build Succeeded 👏 Build Id: 35da74bc-d5af-43af-af80-80f70624bcd0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This is a small fix base on commit ba92be3