Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Xonotic image #654

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Cleanup Xonotic image #654

merged 2 commits into from
Mar 15, 2019

Conversation

markmandel
Copy link
Member

Several small tweaks:

  • Remove server registration with public registry
  • Switch to Docker build image model

@markmandel
Cleanup Xonotic image
d25ccd1 
Several small tweaks:
- Remove server registration with public registry
- Switch to Docker build image model
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Mar 15, 2019
@markmandel markmandel added this to the 0.9.0 milestone Mar 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d260b1d4-552e-4fd2-8a6f-abede1cbd904

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/654/head:pr_654 && git checkout pr_654
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-d25ccd1

cyriltovena
cyriltovena approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you scared someone on stage could join and kill you ^^ ? JK LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee5c850c-adb1-4b38-ae5a-78ff799d3c4f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/654/head:pr_654 && git checkout pr_654
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-66ce6c0

@markmandel markmandel merged commit aae6648 into googleforgames:master Mar 15, 2019
@markmandel markmandel deleted the cleanup/xonotic-public branch March 15, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena