Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end tests for GameServer Pod Deletion #684

Merged
merged 2 commits into from
Apr 3, 2019
Merged

End to end tests for GameServer Pod Deletion #684

merged 2 commits into from
Apr 3, 2019

Conversation

markmandel
Copy link
Member

Context: #678

Wrote tests to confirm that deletion of a GameServer's backing Pod would move a GameServer to Unhealthy.

@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Apr 1, 2019
@markmandel markmandel mentioned this pull request Apr 1, 2019
Closed
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e57ef0c9-1650-4c4c-94fc-03661eb19145

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
End to end tests for GameServer Pod Deletion
d210af7 
Context: googleforgames#678

Wrote tests to confirm that deletion of a GameServer's backing Pod would
move a GameServer to `Unhealthy`.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 474d5d4e-7a03-4dc6-aed5-3c2a4158e3ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/684/head:pr_684 && git checkout pr_684
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-d210af7

cyriltovena
cyriltovena approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a6f730f3-6fe2-4e8c-94cd-dc29e9f4ddcd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/684/head:pr_684 && git checkout pr_684
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-726da3f

@markmandel markmandel merged commit ed8aefe into googleforgames:master Apr 3, 2019
@markmandel markmandel deleted the e2e/deleted-pod branch April 3, 2019 16:29
@pooneh-m pooneh-m mentioned this pull request Apr 10, 2019
Closed
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena