Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a .clang-format file making Google style the default #724

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Apr 18, 2019

This change should probably have been part of PR #716, but I forgot.

.clang-format is a standard file that the clang-format tool(s) look for. This file will tell all clang-format invocations to by-default use the "Google" style. This means that someone running clang-format -i foo.cc within the sdks/cpp/... directory hierarchy will automatically use the correct style.


This change is Reviewable

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d35be90d-fe98-4b96-a70c-c17f2b1e9c63

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/724/head:pr_724 && git checkout pr_724
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-def6823

@devjgm
Copy link
Contributor Author

devjgm commented Apr 18, 2019

fyi, @markmandel

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚚

@markmandel markmandel merged commit 1db42d1 into googleforgames:master Apr 18, 2019
@devjgm devjgm deleted the add-clang-format-dot-file branch April 18, 2019 16:04
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants