Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for public IP connections #227

Merged
merged 11 commits into from
Jan 29, 2024
Merged

feat: add support for public IP connections #227

merged 11 commits into from
Jan 29, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Jan 22, 2024 •
edited
Loading

Add support to Python Connector for Public IP AlloyDB connections:

  • Code changes
  • Fix unit tests
  • Add unit tests
  • Add integration tests
  • Region tags

Fixes #220
Fixes #222

@jackwotherspoon jackwotherspoon self-assigned this Jan 22, 2024
@jackwotherspoon jackwotherspoon changed the title WIP: add support for public IP connections feat: add support for public IP connections Jan 22, 2024
@jackwotherspoon jackwotherspoon marked this pull request as ready for review January 22, 2024 16:46
enocom
enocom approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add fixes #222 and #220 to the commit message (assuming the items for #222 are all addressed here).

tests/unit/test_instance.py Outdated Show resolved Hide resolved
@enocom enocom added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2024
@enocom enocom removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2024
@jackwotherspoon jackwotherspoon merged commit 3ed3d37 into main Jan 29, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the public-ip branch January 29, 2024 18:23
@release-please release-please bot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@cthumuluru cthumuluru Awaiting requested review from cthumuluru

@nancynh nancynh Awaiting requested review from nancynh

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Connector Public IP and Automatic IAM AuthN tests into samples Add support for Public IP Connections
2 participants
@jackwotherspoon @enocom