feat: add support for a custom user agent #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
force-pushed
the
custom-user-agent
branch
4 times, most recently
from
b02c97b
to
39ac2b5
Compare
kurtisvg
approved these changes
Jan 26, 2024
| @@ -54,12 +54,14 @@ def __init__( | |||
| quota_project: Optional[str] = None, | |||
| alloydb_api_endpoint: str = "https://alloydb.googleapis.com", | |||
| enable_iam_auth: bool = False, | |||
| user_agent: Optional[str] = None, | |||
There was a problem hiding this comment.
nit:
Suggested change
| user_agent: Optional[str] = None, | |
| custom_user_agent: Optional[str] = None, |
There was a problem hiding this comment.
I started with that actually and Jack and I've been debating it. Since the AlloyDB Go Connector uses "user agent," I think consistency is probably best here.
enocom
force-pushed
the
custom-user-agent
branch
from
39ac2b5
to
5cb23b6
Compare
When callers initialize a Connector, they can now provide a space-separated list of custom user agents. This custom user agent will be appended to the existing user agent, e.g., alloydb-python-connect/v0.6.0 custom-agent/v1.0.0 other-agent/v2.0.0
enocom
force-pushed
the
custom-user-agent
branch
from
5cb23b6
to
3f26120
Compare
jackwotherspoon
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When callers initialize a Connector, they can now provide a space-separated list of custom user agents. This custom user agent will be appended to the existing user agent, e.g.,
alloydb-python-connect/v0.6.0 custom-agent/v1.0.0 other-agent/v2.0.0