Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glue #1034

Open
elharo opened this issue Nov 13, 2019 · 4 comments · May be fixed by #1253
Open

Glue #1034

elharo opened this issue Nov 13, 2019 · 4 comments · May be fixed by #1253
Labels
best practices JLBPs under library-best-practices p3

Comments

@elharo
Copy link
Contributor

elharo commented Nov 13, 2019

Consider whether we should adopt any parts of https://glue-docs.appspot.com/ for jlbp.dev. E.g. font choices, max width.
@elharo elharo added the best practices JLBPs under library-best-practices label Nov 13, 2019
@garrettjonesgoogle
Copy link
Contributor

#1253 uses Glue

@garrettjonesgoogle garrettjonesgoogle linked a pull request Feb 29, 2020 that will close this issue
Open
@suztomo
Copy link
Contributor

suztomo commented Mar 4, 2020

Glue's CSS is available in CDN https://glue-docs.appspot.com/get-started/cdn/
If we use the CDN, we don't need to maintain the sass files in #1253 .

@garrettjonesgoogle
Copy link
Contributor

The reason for the scss files in #1253 is to support extension, which is used for header tags. I have since removed the glue.scss file in #1253 , and accomplished the same effect using javascript. The PR used the CDN for glue from the beginning and still does.

@suztomo
Copy link
Contributor

suztomo commented Mar 5, 2020

Thank you for clarification.

@elharo elharo added the p3 label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practices JLBPs under library-best-practices p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a navigational structure based on aip.dev garrettjonesgoogle/cloud-opensource-java
3 participants
@suztomo @elharo @garrettjonesgoogle