Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Reduce a number of scripts that implement Sandbox CLI #987

Closed
minherz opened this issue Oct 21, 2022 · 0 comments · Fixed by #1019
Closed

Reduce a number of scripts that implement Sandbox CLI #987

minherz opened this issue Oct 21, 2022 · 0 comments · Fixed by #1019
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@minherz
Copy link
Collaborator

minherz commented Oct 21, 2022

Description

Consolidate CLI implementation inside two scripts

  • sandboxctl (Python)
  • install.sh (Bash)

Host the scripts in the (new) /cli folder. The script execution logic that is based on the relative location of the scripts should be adjusted accordingly.
Call Bash script from Python script for executing "create" and "delete" operations.
Migrate all implementations of "recipes" operations into Python script.
Implement telemetry for "create" and "delete" operations in the Bash script using gcloud pubsub CLI.
Implement telemetry for "recipes" operations in Python script using gcloud pubsub CLI.

Keep Python required packages to minimum.
Update markdown documentation to reflect how Sandbox can be installed.

Warning
This feature breaks "one-click" deployment because it requires
installing Python dependencies and running sandboxctl as two
separate commands.

@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 21, 2022
@minherz minherz added this to the version 0.9 milestone Oct 21, 2022
@minherz minherz self-assigned this Oct 21, 2022
@minherz minherz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 10, 2023
@minherz minherz modified the milestones: version 0.10, version 0.9 Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant