Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with position-based param binding #91

Closed
ChengyuanZhao opened this issue Jun 3, 2019 · 3 comments
Closed

Decide what to do with position-based param binding #91

ChengyuanZhao opened this issue Jun 3, 2019 · 3 comments

Comments

@ChengyuanZhao
Copy link
Member

ChengyuanZhao commented Jun 3, 2019

Currently we do not support binding params by position since Spanner SQL does not support tags for position. We currently do not want to alter users' SQL.

@dzou
Copy link
Contributor

dzou commented Jun 3, 2019

From past discussions with Mark, it sounded like they did some mild parsing of named @ bind variables and then computed the index of the correct variable to use through parsing. This could be one approach we take.

@ChengyuanZhao
Copy link
Member Author

I think we're all just concerned mild parsing can easily turn into mild-to-moderate or even moderate parsing

@elefeint
Copy link
Contributor

Decided not to handle this for Spanner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants