Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ALL_PROXY and HTTP_PROXY #655

Open
enocom opened this issue Mar 16, 2023 · 1 comment
Open

Add support for ALL_PROXY and HTTP_PROXY #655

enocom opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Mar 16, 2023

Feature Description

This is a simple change as described here: https://docs.aiohttp.org/en/stable/client_advanced.html?highlight=proxy#proxy-support.

Customers should have to opt-in to this behavior to prevent any unwanted security issues.

Sample code

No response

Alternatives Considered

No response

Additional Details

No response

@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Mar 16, 2023
@jackwotherspoon
Copy link
Collaborator

Notes: aiohttp.ClientSession object does not natively support socks proxies when using trust_env

async with aiohttp.ClientSession(trust_env=True) as session:

Third-party libs such as aiohttp-socks allow for adding support of socks proxy to aiohttp.ClientSession.

I looked at ability to pass in a custom ClientSession object into Connector() initialization as we do not want to depend on third party library such as aiohttp-socks. Issues arise for sync drivers as custom client session belong to different event loop than the one Connector spins up in the background.

Will re-investigate this issue if it gains traction here.

@jackwotherspoon jackwotherspoon added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Apr 3, 2023
@enocom enocom added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants