Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tile #27

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: tile #27

merged 1 commit into from
Mar 21, 2023

Conversation

subfuzion
Copy link
Member

@subfuzion subfuzion commented Mar 21, 2023

Tile can't return 'Element | undefined'.

Fixes for production / docker build:

$ npm run build
. . .
#16 0.800 info  - Linting and checking validity of types...
#16 5.102 Failed to compile.
#16 5.102 
#16 5.102 ./src/pages/index.tsx:28:14
#16 5.102 Type error: 'Footer' cannot be used as a JSX component.
#16 5.102   Its return type 'Element | undefined' is not a valid JSX element.
#16 5.102     Type 'undefined' is not assignable to type 'Element | null'.
#16 5.102 
#16 5.102   26 |             <GameControls />
#16 5.102   27 |             <Inventory />
#16 5.102 > 28 |             <Footer />
#16 5.102      |              ^
#16 5.102   29 |           </>
#16 5.102   30 |         )}
#16 5.102   31 |       </main>

@subfuzion subfuzion requested a review from LukeSchlangen March 21, 2023 08:09
@LukeSchlangen LukeSchlangen merged commit 50ae62b into main Mar 21, 2023
@LukeSchlangen LukeSchlangen deleted the fix/tile branch March 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants