Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow emulator without firebase project id #63

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

LukeSchlangen
Copy link
Member

The project was failing to spin up locally after we removed the project id. Since developers pulling this down for the first time to run locally might not have a project id, this will enable local development.

@LukeSchlangen LukeSchlangen requested a review from a team as a code owner April 5, 2023 02:34
Copy link
Contributor

@rogerthatdev rogerthatdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LukeSchlangen LukeSchlangen merged commit 30bc11c into main Apr 5, 2023
@LukeSchlangen LukeSchlangen deleted the feature/allow-emulator-without-firebase-project branch April 5, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants