-
Notifications
You must be signed in to change notification settings - Fork 9
feat!: /api/build endpoint, github action #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left quite a few comments, but wanted to add that this is looking really good 👍
It's exciting to see things coming together.
description: 'Greet someone and record the time' | ||
inputs: | ||
github: | ||
description: 'The Github Context JSON object' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of this information we need is populated in environment variables, see:
So, the user shouldn't need to provide this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variables are used, but I think they have to be used in the .github/workflows file, and this action.yaml metadata file just passes these environment variables into the javascript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking like a solid foundation to me.
Breaking Change: Added /api prefix to postbuild routes, and adjusted urls.
This PR handles the creating both a Github action which uploads testing logs to flaky.dev, and a POST endpoint on flaky.dev to which data can be sent and then saved to the Firestore database.
The
POST /api/builds
endpoint can have a raw TAP file string and accompanying metadata uploaded to it. It will then be saved.In the
packages/action
folder, The Github action's main fileindex.js
sends a raw TAP file. It expects a TAP log is saved in a previous step of the workflowBreaking Change: added
/api
prefix to all routes.