Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

feat!: /api/build endpoint, github action #15

Merged
merged 6 commits into from
Jun 18, 2020
Merged

Conversation

StuartRucker
Copy link
Contributor

@StuartRucker StuartRucker commented Jun 17, 2020

Breaking Change: Added /api prefix to postbuild routes, and adjusted urls.

This PR handles the creating both a Github action which uploads testing logs to flaky.dev, and a POST endpoint on flaky.dev to which data can be sent and then saved to the Firestore database.

The POST /api/builds endpoint can have a raw TAP file string and accompanying metadata uploaded to it. It will then be saved.

In the packages/action folder, The Github action's main file index.js sends a raw TAP file. It expects a TAP log is saved in a previous step of the workflow

Breaking Change: added /api prefix to all routes.

@StuartRucker StuartRucker requested review from bcoe and cedpeters June 17, 2020 20:01
Copy link
Contributor

@cedpeters cedpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left quite a few comments, but wanted to add that this is looking really good 👍

It's exciting to see things coming together.

.gitignore Outdated Show resolved Hide resolved
packages/action/action.yaml Outdated Show resolved Hide resolved
description: 'Greet someone and record the time'
inputs:
github:
description: 'The Github Context JSON object'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of this information we need is populated in environment variables, see:

https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables

So, the user shouldn't need to provide this information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variables are used, but I think they have to be used in the .github/workflows file, and this action.yaml metadata file just passes these environment variables into the javascript

packages/action/package.json Outdated Show resolved Hide resolved
packages/action/package.json Outdated Show resolved Hide resolved
packages/action/package.json Outdated Show resolved Hide resolved
packages/api/package.json Outdated Show resolved Hide resolved
packages/api/src/post-build.js Outdated Show resolved Hide resolved
@StuartRucker StuartRucker changed the title feat: /postbuildraw endpoint, github action feat!: /api/build endpoint, github action Jun 18, 2020
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a solid foundation to me.

@StuartRucker StuartRucker merged commit 7b411d5 into master Jun 18, 2020
@StuartRucker StuartRucker deleted the action-serverparse branch June 18, 2020 17:40
@github-actions github-actions bot mentioned this pull request Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants