This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
fix: Github Action handles endpoints ending in / #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Aug 14, 2020
packages/action/package.json
Outdated
| @@ -13,7 +13,8 @@ | |||
| "@actions/core": "^1.2.4", | |||
| "@actions/github": "^3.0.0", | |||
| "node-fetch": "^2.6.0", | |||
| "tap-parser": "^10.0.1" | |||
| "tap-parser": "^10.0.1", | |||
| "url": "^0.11.0" | |||
There was a problem hiding this comment.
actually no need for this dep, url is built into Node.js with the exact same method signature.
StuartRucker
force-pushed
the
actionurl
branch
from
b54a3fa to
4ee4d85
Compare
bcoe
approved these changes
Aug 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the
urlnpm libraryresolvefunction to handle when the inputted URL ends in a slash, since you need to append the post endpoint `/api/build/gh/v1'