fix: Add GCP error reporting log format to cloudevent functions and include panic message in stack trace. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-rosario
force-pushed
the
kennethrosario/fix-error-reporting-cloudevents
branch
from
4102872
to
302e22f
Compare
kenneth-rosario
changed the title
kenneth-rosario
force-pushed
the
kennethrosario/fix-error-reporting-cloudevents
branch
from
9a038fa
to
302e22f
Compare
kenneth-rosario
force-pushed
the
kennethrosario/fix-error-reporting-cloudevents
branch
6 times, most recently
from
7dad763
to
3edf520
Compare
kenneth-rosario
changed the title
HKWinterhalter
approved these changes
Feb 14, 2024
kenneth-rosario
changed the title
kenneth-rosario
force-pushed
the
kennethrosario/fix-error-reporting-cloudevents
branch
from
3edf520
to
8739dff
Compare
…nclude panic message in stack trace.
kenneth-rosario
force-pushed
the
kennethrosario/fix-error-reporting-cloudevents
branch
from
8739dff
to
9909d2b
Compare
HKWinterhalter
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panics are not being formatted correctly for cloud events. We need to use recoverPanic in the wrapper function and re panic after recovering so that the cloudevents go sdk can handle the panic correctly and return a 500 status code.
Had to revert back some versions in go.mod because go-cmp v0.6.0 made the min required go version 1.18.