fix: cancel request context when timeout exceeded #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgeorge
force-pushed
the
garethgeorge/timeouts
branch
3 times, most recently
from
ec88fdd
to
e48a489
Compare
garethgeorge
force-pushed
the
garethgeorge/timeouts
branch
from
e48a489
to
6fa3405
Compare
garethgeorge
changed the title
jrmfg
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the request timeout (signaled by
CLOUD_RUN_TIMEOUT_SECONDS) on the request context so that ff users can write functions that are deadline aware.Functions overrunning
CLOUD_RUN_TIMEOUT_SECONDSmay continue to execute and spend CPU cycles but represent wasted work as the cloud functions runtime typically cuts off the response at this point, no data can be sent.