Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress annotation fails #3

Closed
tarikki opened this issue Oct 2, 2018 · 4 comments
Closed

Ingress annotation fails #3

tarikki opened this issue Oct 2, 2018 · 4 comments

Comments

@tarikki
Copy link

tarikki commented Oct 2, 2018

Steps to reproduce:

  1. Perform steps 1 and 2 in the instructions.
  2. Create a file for the the managed certificate custom object configuration.
  3. Create the managed certificate object from the aforementioned file with the command kubectl create -f my-managed-cert-object.yaml
  4. Run the command kubectl annotate ingress [your-ingress-name] gke.googleapis.com/managed-certificates [your-managed-object-name].

Expected Result::
Ingress is annotated.

Actual result:
kubectl throws the following error: error: at least one annotation update is required

@johnbalvin
Copy link

Did you solve it?

@tarikki
Copy link
Author

tarikki commented Oct 7, 2018

I did ingress annotated with kubectl annotate ingress [your-ingress-name] gke.googleapis.com/managed-certificates=[your-managed-object-name]

but then for some reason the gke-managed-certs did not get me a cert. Because I did this on a pre-existing ingress, don't know if it's because the annotation is still wrong or some other setting is preventing it from working, have not had the time for a retry on a completely clean install. If you progress with this let me know 👍

@tarikki
Copy link
Author

tarikki commented Oct 7, 2018

For another project I followed this tutorial to get renewing certs for kubernetes ingress: https://github.com/ahmetb/gke-letsencrypt

@krzykwas
Copy link
Member

Hi! As for the initial question, I think the missing equals sign was the reason of the error. Additionally the project is still a pre-alpha work-in-progress and to work properly it needs a pull request to ingress to be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants