Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename x-goog-header-params -> x-goog-request-params #5495

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Rename x-goog-header-params -> x-goog-request-params #5495

merged 1 commit into from
Jun 14, 2018

Conversation

evaogbe
Copy link
Contributor

@evaogbe evaogbe commented Jun 14, 2018

Closes #5490

@evaogbe evaogbe requested a review from crwilcox June 14, 2018 18:31
@evaogbe evaogbe requested a review from theacodes as a code owner June 14, 2018 18:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2018
tseaver
tseaver reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should still pass, as they don't rely on the literal string. I don't know enough to comment on the semantics here.

@theacodes theacodes merged commit 839712b into googleapis:master Jun 14, 2018
@evaogbe evaogbe deleted the rename-header-params branch June 14, 2018 19:20
@tseaver tseaver mentioned this pull request Jul 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@theacodes theacodes theacodes approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evaogbe @tseaver @theacodes @googlebot