Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud functions need to be updated #2954

Closed
sofisl opened this issue Dec 22, 2022 · 2 comments
Closed

Cloud functions need to be updated #2954

sofisl opened this issue Dec 22, 2022 · 2 comments
Assignees
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@sofisl
Copy link
Collaborator

sofisl commented Dec 22, 2022

googleapis/google-cloud-node#3621

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2022
@ace-n
Copy link
Contributor

ace-n commented Jan 4, 2023

@rswlkr would you mind telling us which samples this was for?

Note to self:

I looked for Cloud Functions samples with upper-case names (using the grep commands below in the functions directory), but I couldn't find anything:

grep -E "functions\.(http|cloudEvent)\(.[A-Z]" **/*.js
grep -E "exports\.[A-Z]" **/*.js

@grayside grayside added the api: cloudfunctions Issues related to the Cloud Run functions API. label Jan 5, 2023
@kweinmeister kweinmeister added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2023
@pattishin pattishin assigned pattishin and unassigned ace-n Feb 2, 2023
@pattishin
Copy link
Contributor

Closing out as this is referencing older version. As previously noted, directions for valid characters listed https://github.com/googleapis/nodejs-functions/blob/main/src/v2/function_service_client.ts#L869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

5 participants