Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3-networks-hub-and-spoke hardcoded regions us-west1/us-central1 - parameterize them for regionalization security compliance #375

Closed
fmichaelobrien opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels

Comments

@fmichaelobrien
Copy link
Contributor

fmichaelobrien commented Apr 11, 2024

During the 3 section deploy on a clean org ran into hardcoded regions - this will need to be parameterized and fixed to default to northamerica-northeast1 and 2 for security compliance specific to regionalization
see
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/3-networks-hub-and-spoke/envs/shared/main.tf#L22

locals {
  env                = "common"
  environment_code   = "c"
  bgp_asn_number     = var.enable_partner_interconnect ? "16550" : "64514"
  dns_bgp_asn_number = var.enable_partner_interconnect ? "16550" : var.bgp_asn_dns
  default_region1    = "us-west1"
  default_region2    = "us-central1"

verify also the other 3-networks-dual-svpc
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-dual-svpc/envs/shared/remote.tf#L21

see
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/3-networks-dual-svpc/envs/shared/remote.tf#L21

duplicate of terraform-google-modules/terraform-example-foundation#1172

@fmichaelobrien fmichaelobrien self-assigned this Apr 11, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant