Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: ignore googleapis.com links #179

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Jan 15, 2019

These are likely IAM scopes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2019
@jkwlui jkwlui changed the title node: ignore googleapis.com and gstatic.com links These are likely IAM scopes. node: ignore googleapis.com and gstatic.com links Jan 15, 2019
@jkwlui jkwlui requested a review from a team January 15, 2019 21:26
@jkwlui jkwlui self-assigned this Jan 15, 2019
@JustinBeckwith
Copy link
Contributor

What's gstatic?

@jkwlui jkwlui changed the title node: ignore googleapis.com and gstatic.com links node: ignore googleapis.com links Jan 16, 2019
@jkwlui
Copy link
Member Author

jkwlui commented Jan 16, 2019

@JustinBeckwith
Copy link
Contributor

Before merging this - can you do a hammer PR so we don't need to rename all the PRs?

@jkwlui jkwlui closed this Jan 22, 2019
@jkwlui jkwlui reopened this Jan 23, 2019
@JustinBeckwith
Copy link
Contributor

Same ask as before :)

@jkwlui
Copy link
Member Author

jkwlui commented Jan 23, 2019

Will propagate via repo once the CI succeeds here.

@busunkim96 the build is currently failing everywhere because of a lint issue :( Any idea how to fix?

@busunkim96
Copy link
Contributor

@kinwa91 I'll make a PR to fix the lint issue.

@JustinBeckwith JustinBeckwith merged commit acb84e9 into master Jan 24, 2019
@busunkim96 busunkim96 deleted the node-doc-link-checker branch September 9, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants