Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates make target to generate display metadata as well #95

Merged
merged 3 commits into from
May 27, 2023
Merged

feat: updates make target to generate display metadata as well #95

merged 3 commits into from
May 27, 2023

Conversation

g-awmalik
Copy link
Collaborator

No description provided.

@g-awmalik g-awmalik requested review from a team and gtsorbo as code owners May 20, 2023 23:34
@gtsorbo
Copy link
Contributor

gtsorbo commented May 24, 2023

/gcbrun

1 similar comment
@gtsorbo
Copy link
Contributor

gtsorbo commented May 24, 2023

/gcbrun

@g-awmalik
Copy link
Collaborator Author

g-awmalik commented May 25, 2023 •
edited
Loading

@gtsorbo - the int test is complaining about project_id_standalone but I see that as an output from the test setup config. Have you seen this before?

@g-awmalik
Copy link
Collaborator Author

Actually, here's the problem:

Error: Error enabling the Compute Engine API required to delete the default network: Error waiting for Enable Project "secure-cicd-singleproj-b5ff" Services: [compute.googleapis.com]: Error code 3, message: [service compute.googleapis.com encountered internal error: type: "googleapis.com" subject: "160009" ] with failed services [compute.googleapis.com]

b/284117246 & b/283908020 for context.

@gtsorbo gtsorbo merged commit a0d17de into main May 27, 2023
@gtsorbo gtsorbo deleted the feat/metadata-udpate branch May 27, 2023 01:13
@release-please release-please bot mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsorbo gtsorbo gtsorbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-awmalik @gtsorbo