Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cmek into reidentification #137

Merged
merged 3 commits into from
Sep 14, 2021
Merged

add cmek into reidentification #137

merged 3 commits into from
Sep 14, 2021

Conversation

erlanderlo
Copy link
Member

@erlanderlo erlanderlo commented Sep 13, 2021 •
edited
Loading

fixes: #98

  • Tests pass
  • Appropriate changes to README are included in PR

This will be rebased once previous PR is merged

@erlanderlo
Copy link
Member Author

erlanderlo commented Sep 13, 2021 •
edited
Loading

main review starts at this commit: 3ed8816

daniel-cit
daniel-cit approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just need to include the artifactregistry.googleapis.com service in the test setup

@daniel-cit daniel-cit self-requested a review September 14, 2021 16:39
daniel-cit
daniel-cit approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just need to include the artifactregistry.googleapis.com service in the test setup

@bharathkkb bharathkkb merged commit e1c0c0c into GoogleCloudPlatform:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cit daniel-cit daniel-cit approved these changes

@bharathkkb bharathkkb bharathkkb approved these changes

@morgante morgante Awaiting requested review from morgante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sensitive data resources
3 participants
@erlanderlo @bharathkkb @daniel-cit