Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds policies and step for terraform-validator in build #170

Merged
merged 63 commits into from
Nov 29, 2021
Merged

Adds policies and step for terraform-validator in build #170

merged 63 commits into from
Nov 29, 2021

Conversation

amandakarina
Copy link
Collaborator

@amandakarina amandakarina commented Oct 6, 2021 •
edited
Loading

Fixes #139

  • Tests pass
  • Appropriate changes to README are included in PR

@amandakarina
Adds policies and step for terraform-validator in build
5b94461
@amandakarina
Removes unnecessary files
62f6c41
@amandakarina
Add terraform validator install
cac77f8
@amandakarina
Fixes validator version
78ebbac
@amandakarina
Revert setup
8529adc
@amandakarina
Adds mv terraform-validator to /usr/bin/
125b9bb
@amandakarina
Fixes fixture path
3e55de8
@amandakarina
Fixes build folder
53bf27b
@amandakarina
Removes creation 3 projects
140230b
@amandakarina
Adds export setup outputs
e8eb2b5
@amandakarina
Adds export setup outputs
ccd4677
@amandakarina
Adds export setup outputs
85097f0
@amandakarina
Adds export setup outputs
8706ac7
@amandakarina
Sets access token
90d328d
@amandakarina
Test iam
e47b719
@amandakarina
Add converge step to test iam
c1ff677
@amandakarina
Sets GOOGLE_IMPERSONATE_SERVICE_ACCOUNT before plan
9b9f7c8
@amandakarina
Teste validate in the same step as converge
1bd9c58
@amandakarina
Adds validate in the same step as create
9508391
@amandakarina
Fix build step, adds dir creation for tmp_plan
11a6cb7
@amandakarina
Fixes dir creation
71db26f
@amandakarina
Fixes dir creation
cb66f02
@amandakarina
fix project parameter
6d77efe
bharathkkb
bharathkkb reviewed Oct 7, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests for this

test/terraform-validate.sh Outdated Show resolved Hide resolved
test/terraform-validate.sh Outdated Show resolved Hide resolved
test/terraform-validate.sh Outdated Show resolved Hide resolved
@amandakarina amandakarina marked this pull request as ready for review November 1, 2021 12:29
bharathkkb
bharathkkb requested changes Nov 12, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some readme updates as to how users can use this. Also looks like some empty files are being checked in
examples/simple-example/.json, examples/simple-example/simple_example.json

Makefile Show resolved Hide resolved
test/terraform-validator.sh Outdated Show resolved Hide resolved
test/terraform-validator.sh Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 1ddf387 into GoogleCloudPlatform:main Nov 29, 2021
@amandakarina amandakarina deleted the feat/creates-validator-policies branch November 29, 2021 17:20
bharathkkb added a commit that referenced this pull request Dec 2, 2021
@bharathkkb
chore: clean up some empty files from #170
3a5286f
@bharathkkb bharathkkb mentioned this pull request Dec 2, 2021
Merged
erlanderlo pushed a commit that referenced this pull request Dec 3, 2021
@bharathkkb
chore: clean up some empty files from #170 (#202)
39ec2b4 
* chore: clean up some empty files from #170

* Delete simple_example.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cit daniel-cit daniel-cit left review comments

@bharathkkb bharathkkb bharathkkb approved these changes

@morgante morgante Awaiting requested review from morgante

@erlanderlo erlanderlo Awaiting requested review from erlanderlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create validator policies
4 participants
@amandakarina @bharathkkb @erlanderlo @daniel-cit