Trim main module outputs #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-cit
requested review from
bharathkkb,
erlanderlo and
morgante
as code owners
erlanderlo
approved these changes
Oct 13, 2021
bharathkkb
approved these changes
Oct 13, 2021
| description = "The Keyring full name for the KMS Customer Managed Encryption Keys." | ||
| value = module.data_governance.cmek_keyring_full_name | ||
|
|
||
| depends_on = [ |
There was a problem hiding this comment.
Can we also get rid of other time_sleep.wait_for_bridge_propagation except for one or two key outputs that users will use in subsequent configs?
There was a problem hiding this comment.
I removed the depends_on from the outputs not explicitly used by the examples.
Should we add some kind of note to the user regarding the propagation issue?
@bharathkkb
There was a problem hiding this comment.
@daniel-cit users will likely use it in same pattern as examples. We can add additional based on feedback
erlanderlo
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148