Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add predefined security groups #185

Merged
merged 13 commits into from
Dec 7, 2021
Merged

feat: Add predefined security groups #185

merged 13 commits into from
Dec 7, 2021

Conversation

daniel-cit
Copy link
Collaborator

@daniel-cit daniel-cit commented Nov 17, 2021 •
edited
Loading

This PR adds a set of predefined security groups

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@daniel-cit daniel-cit marked this pull request as ready for review November 19, 2021 21:17
erlanderlo
erlanderlo approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM…We need to discuss if we should remove further so left comments as reminder.

iam.tf Show resolved Hide resolved
iam.tf Outdated Show resolved Hide resolved
erlanderlo
erlanderlo reviewed Dec 3, 2021
View reviewed changes
iam.tf Show resolved Hide resolved
erlanderlo
erlanderlo reviewed Dec 3, 2021
View reviewed changes
iam.tf Outdated Show resolved Hide resolved
erlanderlo
erlanderlo reviewed Dec 3, 2021
View reviewed changes
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches our analysis. see a few comments on recent updates to the doc. once that doc is finalized, this should be ready!

@daniel-cit daniel-cit changed the title Add predefined security groups feat: Add predefined security groups Dec 7, 2021
erlanderlo
erlanderlo approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - matches our doc

@erlanderlo erlanderlo merged commit d643faf into GoogleCloudPlatform:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb left review comments

@erlanderlo erlanderlo erlanderlo approved these changes

@morgante morgante Awaiting requested review from morgante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-cit @bharathkkb @erlanderlo