Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a random suffix in the keyring creation #201

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Added a random suffix in the keyring creation #201

merged 2 commits into from
Dec 2, 2021

Conversation

LuizSDCit
Copy link
Collaborator

@LuizSDCit LuizSDCit commented Dec 1, 2021

Fixes #166

Added a random suffix in the keyring creation

  • Tests pass
  • Appropriate changes to README are included in PR

@LuizSDCit LuizSDCit marked this pull request as ready for review December 1, 2021 20:03
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; consolidates the naming in a common place

Copy link
Collaborator

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit 2d6496d into GoogleCloudPlatform:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify resources that could have a random suffix added to avoid conflict in repeated deploys
4 participants