Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add troubleshooting #208

Merged

Conversation

LuizSDCit
Copy link
Collaborator

@LuizSDCit LuizSDCit commented Dec 7, 2021

Part of issue #177

Added troubleshooting

  • Tests pass
  • Appropriate changes to README are included in PR

@LuizSDCit LuizSDCit changed the title [DRAFT] Feat: Add troubleshooting [DRAFT] feat: Add troubleshooting Dec 7, 2021
@LuizSDCit LuizSDCit changed the title [DRAFT] feat: Add troubleshooting feat: Add troubleshooting Dec 7, 2021
@LuizSDCit LuizSDCit marked this pull request as ready for review December 7, 2021 20:15
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. suggest to copy the doc into a gDoc for grammar, spelling checks/suggestions. I tried to catch what I could.

Some thoughts to consider as well.

docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . minor nit

docs/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
@LuizSDCit LuizSDCit requested a review from erlanderlo December 10, 2021 17:11
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@erlanderlo erlanderlo merged commit 66ed0a0 into GoogleCloudPlatform:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants