Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regional DLP readme review #216

Merged
merged 6 commits into from
Dec 10, 2021
Merged

fix: Regional DLP readme review #216

merged 6 commits into from
Dec 10, 2021

Conversation

amandakarina
Copy link
Collaborator

Fixes partially #37

  • Tests pass
  • Appropriate changes to README are included in PR

@amandakarina amandakarina marked this pull request as draft December 9, 2021 19:35
@daniel-cit daniel-cit marked this pull request as ready for review December 9, 2021 22:24
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but resolve convo

…ina/terraform-google-secured-data-warehouse into fix/review-regional-dlp-readme
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlanderlo erlanderlo merged commit 6a1ba40 into GoogleCloudPlatform:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants