Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make Python Flex template bq-to-bq de-identify and re-identify data #257

Conversation

vfigueiredo-cit
Copy link
Collaborator

The Python Regional DLP Transform BigQuery to BigQuery flex template now can de-identify and re-identify data.

Fixes partially #101

…on(bq-to-bq) do both. de-identify and re-identify data
@vfigueiredo-cit vfigueiredo-cit marked this pull request as ready for review December 24, 2021 18:49
@LuizSDCit LuizSDCit changed the title Make Python Flex template bq-to-bq de-identify and re-identify data feat: Make Python Flex template bq-to-bq de-identify and re-identify data Dec 27, 2021
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As you improve the de-id functions, please also cleanup the re-id functions, since the code is almost duplicated.

Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but otherwise LGTM

Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuizSDCit LuizSDCit requested a review from erlanderlo January 6, 2022 11:40
@erlanderlo erlanderlo merged commit 29079d6 into GoogleCloudPlatform:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants