Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform step 1-data-ingestion into module base-data-ingestion #72

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Transform step 1-data-ingestion into module base-data-ingestion #72

merged 1 commit into from
Jul 29, 2021

Conversation

daniel-cit
Copy link
Collaborator

@daniel-cit daniel-cit commented Jul 28, 2021 •
edited
Loading

Fixes #44

This PR transforms the step 1-data-ingestion in to a module base-data-ingestion

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

erlanderlo
erlanderlo approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! LGTM

@daniel-cit daniel-cit requested a review from morgante July 29, 2021 13:32
@morgante morgante merged commit a6e0af0 into GoogleCloudPlatform:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlanderlo erlanderlo erlanderlo approved these changes

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove steps / update to follow Terraform module standards
3 participants
@daniel-cit @morgante @erlanderlo