Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds variable for receive region in pub/sub #78

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Adds variable for receive region in pub/sub #78

merged 5 commits into from
Aug 5, 2021

Conversation

LuizSDCit
Copy link
Collaborator

@LuizSDCit LuizSDCit commented Aug 4, 2021

This feature allows you to restrict the region where Pub/Sub massage will be stored. Will prepare the module for issue #39.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Small nit

modules/base-data-ingestion/variables.tf Outdated Show resolved Hide resolved
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@LuizSDCit
Copy link
Collaborator Author

LGTM
Small nit

Nice catch! Thanks

@LuizSDCit LuizSDCit requested a review from bharathkkb August 5, 2021 19:31
@bharathkkb bharathkkb merged commit 53dfe3d into GoogleCloudPlatform:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants