-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add root main module #80
feat: add root main module #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @LuizSDCit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add the examples/simple_example to tests in a follow up PR.
/cc @erlanderlo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! and lgtm; can address the comments either in this PR or a subsequant one, but plz indicate the path you'd like to take by responding to the comments.
@bharathkkb , I was checking the issues with Amanda and we notice that we also have this issue #60 that asks for remove the simple_example. Do you think that we should remove the simples_exemple or add it to the tests? |
@LuizSDCit we can keep the simple example as it is no longer from the cookie cutter template. We can add the tests in a follow up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit; great updates!
This issue create a top level module that starts to use a consistent drz, it is helpful for #39.