Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add root main module #80

Merged
merged 9 commits into from
Aug 13, 2021
Merged

feat: add root main module #80

merged 9 commits into from
Aug 13, 2021

Conversation

LuizSDCit
Copy link
Collaborator

@LuizSDCit LuizSDCit commented Aug 10, 2021

This issue create a top level module that starts to use a consistent drz, it is helpful for #39.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @LuizSDCit

README.md Outdated Show resolved Hide resolved
examples/simple_example/variables.tf Outdated Show resolved Hide resolved
@LuizSDCit LuizSDCit requested a review from bharathkkb August 10, 2021 18:18
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add the examples/simple_example to tests in a follow up PR.
/cc @erlanderlo

@bharathkkb bharathkkb changed the title Feat/basic main feat: add root main module Aug 10, 2021
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! and lgtm; can address the comments either in this PR or a subsequant one, but plz indicate the path you'd like to take by responding to the comments.

outputs.tf Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/simple_example/outputs.tf Show resolved Hide resolved
@LuizSDCit
Copy link
Collaborator Author

We should also add the examples/simple_example to tests in a follow up PR.
/cc @erlanderlo

@bharathkkb , I was checking the issues with Amanda and we notice that we also have this issue #60 that asks for remove the simple_example. Do you think that we should remove the simples_exemple or add it to the tests?

@bharathkkb
Copy link
Member

@LuizSDCit we can keep the simple example as it is no longer from the cookie cutter template. We can add the tests in a follow up PR

Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit; great updates!

outputs.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 5703861 into GoogleCloudPlatform:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants