Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple example in the test #87

Merged
merged 9 commits into from
Aug 19, 2021
Merged

Added simple example in the test #87

merged 9 commits into from
Aug 19, 2021

Conversation

LuizSDCit
Copy link
Collaborator

@LuizSDCit LuizSDCit commented Aug 17, 2021

Fixes #83

Added the simple_example to the integration tests.

  • Tests pass
  • Appropriate changes to README are included in PR

@LuizSDCit LuizSDCit marked this pull request as ready for review August 17, 2021 21:34
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuizSDCit

examples/simple_example/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! minor things to consider.

examples/simple_example/variables.tf Outdated Show resolved Hide resolved
test/fixtures/simple_example/variables.tf Outdated Show resolved Hide resolved
test/fixtures/simple_example/outputs.tf Outdated Show resolved Hide resolved
test/fixtures/simple_example/main.tf Show resolved Hide resolved
@LuizSDCit LuizSDCit requested a review from erlanderlo August 18, 2021 20:53
@bharathkkb bharathkkb merged commit 2175631 into GoogleCloudPlatform:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simple_example to the test
3 participants