Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test on arm64 #82

Open
briandealwis opened this issue Jun 9, 2021 · 3 comments
Open

Build and test on arm64 #82

briandealwis opened this issue Jun 9, 2021 · 3 comments
Assignees

Comments

@briandealwis
Copy link
Member

We discovered that the arm64 images were based on amd64 base images (#78) that went undiscovered as

  1. We weren't running tests on arm64 — I wasn't aware that Travis supported arm64.
  2. I was performing manual tests using Docker Desktop for M1 and Minikube, and Docker Desktop installs binfmt_exec extensions to allow non-native images.

We're also hitting frequent rate limiting issues with Docker Hub on Travis. Since Github Actions supports builds in amd64 and arm64, so we should run tests there.

@aaron-prindle
Copy link

aaron-prindle commented Jun 9, 2021

I made this related issue on skaffold repo - GoogleContainerTools/skaffold#5989

Would this github action be on container-debug-support repo or skaffold repo? Thanks

@briandealwis
Copy link
Member Author

I think this repo for now. We’ve talked about merging this repo into skaffold but a bit hesitant due to how to build images and test.

@aaron-prindle
Copy link

Re: Since Github Actions supports builds in amd64 and arm64, so we should run tests there.

I think that Github only supports arm64 via self-hosted runners:
https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
actions/runner-images#2552 (comment)
actions/runner-images#2187

Just to clarify, was this your understanding when comparing Travis vs Github actions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants