Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputDigest is not supported by CustomTemplateTagger #5660

Closed
mikekamornikov opened this issue Apr 9, 2021 · 2 comments · Fixed by #5661
Closed

InputDigest is not supported by CustomTemplateTagger #5660

mikekamornikov opened this issue Apr 9, 2021 · 2 comments · Fixed by #5661

Comments

@mikekamornikov
Copy link
Contributor

Expected behavior

I expect image tag with both some custom text and input digest created with customTemplate tagPolicy

Actual behavior

$ skaffold build -p test-custom-template
creating runner: creating tagger: creating tagger: creating components: unknown component for custom template: DIGEST {GitTagger:<nil> ShaTagger:<nil> EnvTemplateTagger:<nil> DateTimeTagger:<nil> CustomTemplateTagger:<nil> InputDigest:0x7a479b8}
. If above error is unexpected, please open an issue https://github.com/GoogleContainerTools/skaffold/issues/new to report this error.

Information

  • Skaffold version: v1.21.0-29-g89b83154e-dirty
  • Operating system: macOS 10.15.7
  • Installed via: built from master
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta14
kind: Config
profiles:
- name: test-custom-template
  build:
    tagPolicy:
      customTemplate:
        template: "release-aaa-{{.DIGEST}}"
        components:
        - name: DIGEST
          inputDigest: {}
    artifacts:
    - image: quay.io/my/project
      context: ../../..
      bazel:
        target: //project:docker.tar

Steps to reproduce the behavior

  1. clone this repo and build skaffold with LOCAL=true make install
  2. skaffold build -p test-custom-template
  3. ...
@mikekamornikov
Copy link
Contributor Author

@piotr-szybicki This one is related to #5192 .

@tejal29
Copy link
Member

tejal29 commented Apr 12, 2021

will be fixed by #5661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants